Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new product] add valkey #6525

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[new product] add valkey #6525

wants to merge 3 commits into from

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jan 7, 2025 •
edited
Loading

@chenrui333 chenrui333 added the new-product This PR adds a new product to the website. label Jan 7, 2025
usta
usta requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@usta usta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

products/valkey.md Outdated Show resolved Hide resolved
@chenrui333
valkey: add 8.0.2
61a2d14 
Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 requested a review from usta January 8, 2025 04:18
usta
usta requested changes Jan 8, 2025
View reviewed changes
Copy link
Member

@usta usta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple icons dont have an icon named valkey so that tag needs to be removed

products/valkey.md Outdated Show resolved Hide resolved
@chenrui333 @usta
valkey: remove iconSlug
f5eb77f 
Co-authored-by: Ömer Fadıl USTA <[email protected]>
@chenrui333 chenrui333 requested a review from usta January 9, 2025 15:26
usta
usta approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@usta usta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might laugh but i have checked again if it have a new version or not just before writing this :D

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usta usta usta approved these changes

Assignees
No one assigned
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @usta